Initial commit of host metrics disk scraper #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
james-bebbington
force-pushed
the
hostmetrics-disk
branch
from
44e10bc
to
4c23ef1
Compare
bogdandrutu
reviewed
May 6, 2020
bogdandrutu
reviewed
May 6, 2020
| } | ||
|
|
||
| // Close | ||
| func (s *Scraper) Close(ctx context.Context) error { |
There was a problem hiding this comment.
Would suggest to use Shutdown instead of "Close".
There was a problem hiding this comment.
Alright but I'll refactor in another PR again since this is in the Scraper interface
receiver/hostmetricsreceiver/internal/scraper/diskscraper/disk_scraper.go
Outdated
Show resolved
Hide resolved
james-bebbington
force-pushed
the
hostmetrics-disk
branch
2 times, most recently
from
c51a390
to
c2d0308
Compare
bogdandrutu
approved these changes
May 7, 2020
receiver/hostmetricsreceiver/internal/scraper/diskscraper/factory_test.go
Outdated
Show resolved
Hide resolved
james-bebbington
force-pushed
the
hostmetrics-disk
branch
from
c2d0308
to
026710b
Compare
Codecov Report
@@ Coverage Diff @@
## master #921 +/- ##
==========================================
+ Coverage 85.49% 85.54% +0.05%
==========================================
Files 178 181 +3
Lines 13322 13430 +108
==========================================
+ Hits 11389 11489 +100
- Misses 1479 1484 +5
- Partials 454 457 +3
Continue to review full report at Codecov.
|
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking Issue:
#847
Description:
Added disk scraper to the hostmetricsreceiver which uses gopsutil to collect disk related metrics