[chore](featuregate): use errors.Join instead of multierr.Append #9410
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9410 +/- ##
=======================================
Coverage 90.45% 90.45%
=======================================
Files 346 346
Lines 18131 18131
=======================================
Hits 16400 16400
Misses 1399 1399
Partials 332 332 ☔ View full report in Codecov by Sentry. |
| @@ -59,7 +58,7 @@ func (f *flagValue) Set(s string) error { | |||
| case '+': | |||
| id = id[1:] | |||
| } | |||
| errs = multierr.Append(errs, f.reg.Set(id, val)) | |||
| errs = errors.Join(errs, f.reg.Set(id, val)) | |||
There was a problem hiding this comment.
I can check on Monday, but I believe this will change the output of the error format in this case. I believe to be equivalent using errors.Join you'll need to keep a slice of errors and then join them at the end.
There was a problem hiding this comment.
I believe it needs to look like this: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/5a3a3eaa01949c870a8c1cd4de7ff8203c0ad9ff/pkg/ottl/parser.go#L110-L112. You can see the berfore-and-after here: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/29332/files#diff-79e887c0c48e52e9341081ec2f052ca7b3ecc9ec98dd657e7189bc559c9a80fb
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Description: use errors.Join instead of multierr.Append
Link to tracking Issue: #8210