[configretry] validate max_elapsed_time #9489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
check_max_elapsed_time
branch
2 times, most recently
from
e5b1754 to
5e61370
Compare
dmitryax
reviewed
Feb 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9489 +/- ##
=========================================
+ Coverage 0 90.44% +90.44%
=========================================
Files 0 346 +346
Lines 0 18137 +18137
=========================================
+ Hits 0 16404 +16404
- Misses 0 1401 +1401
- Partials 0 332 +332 ☔ View full report in Codecov by Sentry. |
atoulme
force-pushed
the
check_max_elapsed_time
branch
from
5e61370 to
a3abcda
Compare
dmitryax
reviewed
Feb 6, 2024
atoulme
force-pushed
the
check_max_elapsed_time
branch
from
a3abcda to
7fb68f2
Compare
dmitryax
approved these changes
Feb 7, 2024
dmitryax
reviewed
Feb 7, 2024
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
mx-psi
added
needed-for-1.0
release:required-for-ga
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Validate
max_elapsed_time, ensure it is larger thanmax_intervalandinitial_intervalrespectively.