[chore] [exporterhelper] Remove duplicated code between exporter helpers #9603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
simplify-exporter-helper
branch
from
fbbd2d5
to
a0095a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9603 +/- ##
==========================================
+ Coverage 90.62% 90.70% +0.08%
==========================================
Files 347 347
Lines 18232 18199 -33
==========================================
- Hits 16522 16507 -15
+ Misses 1381 1369 -12
+ Partials 329 323 -6 ☔ View full report in Codecov by Sentry. |
dmitryax
force-pushed
the
simplify-exporter-helper
branch
2 times, most recently
from
7f3a16d
to
251aaf0
Compare
dmitryax
force-pushed
the
simplify-exporter-helper
branch
from
251aaf0
to
971706f
Compare
dmitryax
changed the title
sfc-gh-bdrutu
approved these changes
Feb 20, 2024
bogdandrutu
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.