-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporterhelper] Add default batching for OTLP data type #9738
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9738 +/- ##
==========================================
+ Coverage 91.14% 91.32% +0.18%
==========================================
Files 353 356 +3
Lines 18772 19163 +391
==========================================
+ Hits 17109 17500 +391
Misses 1335 1335
Partials 328 328 ☔ View full report in Codecov by Sentry. |
20e1707
to
3fd7a3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the merge and mergeSplit function. This makes using exporter batching framework much easier.
064c93c
to
c113899
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just two minor nits to clarify the code
Make the exporter batching capability to be available for the regular exporter helper without using custom requests.
**Description:** Add a new feature in splunk hec exporter - utilitize batching framework open-telemetry/opentelemetry-collector#9738 in splunk hec exporter - adds batcher config in splunk hec exporter config and append it as exporter option if enabled **Link to tracking Issue:** Resolves #32545 **Testing:** Added unit test for the config **Documentation:** Updated the README file
Introduce default batching functionality based on the internal data type (pdata). This makes the exporter batching capability available to the regular exporter helpers without using custom requests.
Updates #8122