Fix unit tests on Windows #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
go.mod
Outdated
| @@ -56,7 +56,7 @@ require ( | |||
| go.opencensus.io v0.22.3 | |||
| go.uber.org/zap v1.10.0 | |||
| golang.org/x/net v0.0.0-20200324143707-d3edc9973b7e // indirect | |||
| golang.org/x/sys v0.0.0-20200408040146-ea54a3c99b9b // indirect | |||
| golang.org/x/sys v0.0.0-20200408040146-ea54a3c99b9b | |||
There was a problem hiding this comment.
Sneaking this change in. A direct reference to x/sys was actually introduced in #953
There was a problem hiding this comment.
Would suggest to always split in separate PRs :)
There was a problem hiding this comment.
Alright 👍 Rolled this back in this branch
james-bebbington
changed the title
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
==========================================
- Coverage 85.62% 85.62% -0.01%
==========================================
Files 184 184
Lines 13087 13080 -7
==========================================
- Hits 11206 11200 -6
+ Misses 1434 1432 -2
- Partials 447 448 +1
Continue to review full report at Codecov.
|
james-bebbington
force-pushed
the
fix-unit-tests-for-windows
branch
from
ff69230 to
edb7e82
Compare
bogdandrutu
reviewed
May 18, 2020
go.mod
Outdated
| @@ -56,7 +56,7 @@ require ( | |||
| go.opencensus.io v0.22.3 | |||
| go.uber.org/zap v1.10.0 | |||
| golang.org/x/net v0.0.0-20200324143707-d3edc9973b7e // indirect | |||
| golang.org/x/sys v0.0.0-20200408040146-ea54a3c99b9b // indirect | |||
| golang.org/x/sys v0.0.0-20200408040146-ea54a3c99b9b | |||
There was a problem hiding this comment.
Would suggest to always split in separate PRs :)
james-bebbington
force-pushed
the
fix-unit-tests-for-windows
branch
from
edb7e82 to
b0df43d
Compare
bogdandrutu
approved these changes
May 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
==========================================
+ Coverage 85.62% 85.64% +0.01%
==========================================
Files 184 184
Lines 13087 13080 -7
==========================================
- Hits 11206 11202 -4
+ Misses 1434 1431 -3
Partials 447 447
Continue to review full report at Codecov.
|
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Remove otel/sdk dependency from grpctrace Use otel/trace/testtrace instead and cleanup testing code. * Update httptrace to not depend on the SDK Update testing to use api/trace/testtrace instead. * Add changes to Changelog * Restore check for `http.local` attr on `http.getconn`
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#983) Bumps [boto3](https://github.com/boto/boto3) from 1.20.12 to 1.20.13. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.20.12...1.20.13) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
* update to demo 1.7 Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update to demo 1.7 Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes several unit tests that were failling on Windows:
configgrpc,configgrpc_test&opencensusexporter.factory: On Windows, callingx509.SystemCertPool()directly returns an error (see the discussion here crypto/x509: make SystemCertPool work on Windows? golang/go#16736), but as per the documentation, leavingTLSConfig.RootCAsasnilwill still correctly validate certificates against the system cert pool. Fixing the failing tests on Windows required some minor code changes so that we never load the system cert pool, and just rely onRootCAsbeingnilinstead. This made an existing test that checked if the call tox509.SystemCertPool()failed redundant.configgrpc_test: Generalised a couple of checks against expected errors so they will pass on Windows (due to slightly different error responses).opencensus_test&otlp_test: A tmp file was opened and then deleted before being closed, which raises a file-in-use error on Windows ==> Close the file before deleting it.Link to tracking Issue:
#854
See also:
#976