Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Do not log warning when feature gate is enabled #9852

Merged
merged 1 commit into from
Mar 27, 2024
Merged

[chore] Do not log warning when feature gate is enabled #9852

merged 1 commit into from
Mar 27, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Mar 26, 2024

Description: Fixes #9753

This was referenced Mar 26, 2024
Merged
Closed
@mx-psi mx-psi marked this pull request as ready for review March 26, 2024 12:38
@mx-psi mx-psi requested review from a team and Aneurysm9 March 26, 2024 12:38
@codecov Codecov
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.13%. Comparing base (5f9a7d7) to head (71057cf).

Files Patch % Lines
config/internal/warning.go 0.00% 1 Missing ⚠️
internal/localhostgate/featuregate.go 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9852   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files         353      353           
  Lines       18728    18728           
=======================================
  Hits        17067    17067           
  Misses       1333     1333           
  Partials      328      328

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dashpole
Copy link
Contributor

Thanks @mx-psi!

cc @richard-bain

@mx-psi mx-psi merged commit 351fcf6 into open-telemetry:main Mar 27, 2024
55 of 66 checks passed
@mx-psi mx-psi deleted the mx-psi/warn branch March 27, 2024 11:07
@github-actions github-actions bot added this to the next release milestone Mar 27, 2024
mx-psi added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Mar 27, 2024
@mx-psi
[chore] Sync internal/common/localhostgate (#31965)
80bbf5e 
**Description:** Syncs localhostgate with core after changes in
open-telemetry/opentelemetry-collector/pull/9852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@dmitryax dmitryax dmitryax approved these changes

@dashpole dashpole dashpole approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.98.0
Development

Successfully merging this pull request may close these issues.

DOS warning about binding to 0.0.0.0 does not apply to serverless environments
4 participants
@mx-psi @dashpole @dmitryax @TylerHelmuth