Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [exporterhelper] Update stale batchSender comments #9884

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

carsonip
Copy link
Contributor

@carsonip carsonip commented Apr 3, 2024

Description:

Update comment as fields may have been renamed.

No functional change and should not require a changelog.

@carsonip carsonip requested review from a team and bogdandrutu April 3, 2024 13:41
Update comment as fields may have been renamed.
@carsonip carsonip force-pushed the fix-batchsender-comment branch from 52c1ea5 to 395d767 Compare April 3, 2024 13:41
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (fd0d0da) to head (18db11e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9884   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files         357      357           
  Lines       16501    16501           
=======================================
  Hits        15173    15173           
  Misses       1000     1000           
  Partials      328      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 9, 2024
@dmitryax dmitryax changed the title [exporterhelper] Update stale batchSender comments [chore] [exporterhelper] Update stale batchSender comments Apr 9, 2024
@dmitryax dmitryax merged commit 0d62e4f into open-telemetry:main Apr 11, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants