-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sdk-config.yaml starter template w/ references to env vars #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with fixes on endpoints.
…v var substitution default syntax (#3948) Fixes #3752. Implementation of the configuration working group recommendation as [described here](#3752 (comment)). - Adds definition for `OTEL_EXPERIMENTAL_CONFIG_FILE `, which ignores other env vars when evaluating, except env var substitution references - Adds new env var substitution default syntax `${ENVVAR:-defaultValue}` - Paired with open-telemetry/opentelemetry-configuration#76, which defines a new [sdk-config.yaml](https://github.com/jack-berg/opentelemetry-configuration/blob/starter-template/examples/sdk-config.yaml) starter template referencing all env vars that map cleanly.
d05a637
to
73cd03f
Compare
This is a loose end from open-telemetry/opentelemetry-specification#3948 I've pushed an additional commit and marked as ready for review. Please review when you have the chance. cc @open-telemetry/configuration-maintainers |
@tsloughter, @marcalff, @codeboten can you take another look? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see more comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments on endpoints.
@marcalff would appreciate you taking another look when you can. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see editorial changes.
…v var substitution default syntax (open-telemetry#3948) Fixes open-telemetry#3752. Implementation of the configuration working group recommendation as [described here](open-telemetry#3752 (comment)). - Adds definition for `OTEL_EXPERIMENTAL_CONFIG_FILE `, which ignores other env vars when evaluating, except env var substitution references - Adds new env var substitution default syntax `${ENVVAR:-defaultValue}` - Paired with open-telemetry/opentelemetry-configuration#76, which defines a new [sdk-config.yaml](https://github.com/jack-berg/opentelemetry-configuration/blob/starter-template/examples/sdk-config.yaml) starter template referencing all env vars that map cleanly.
Resolves #55.
Part of the configuration working group recommendation on how to move forward with #3752 as described here.
sdk-migration-config.yaml
to the examples directory, which includes env var substitution references to all env vars which map cleanly to file configsdk-config.yaml
to the example directory, which is identical tosdk-migration-config.yaml
, but without env var substitution references