First Commit #109
Merged
First Commit #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
approved these changes
Mar 10, 2022
| @@ -0,0 +1,97 @@ | |||
| /* | |||
| @@ -0,0 +1,16 @@ | |||
| && gpg --keyserver ha.pool.sks-keyservers.net --recv-keys B42F6819007 | |||
| | Apr-util | 1.6.1 | | ||
| | Expat | 2.3.0 | | ||
| | Boost | 1.75.0 | | ||
| | Opentelemetry - C++ SDK | 1.0.0-rc1 | |
There was a problem hiding this comment.
Nit - good to use the stable version of the otel-cpp library probably as separate PR later.
|
LGTM for initial commit. Would be good to have build and tests onboarded to github actions as separate PR once ready. |
|
@lalitb Could you please merge the PR on my behalf. Thanks |
6 tasks
marcalff
added
the
Webserver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR which contains source code for the CISCO contribution of Apache Opentelemetry module.