Dockerfile edit #112
Merged
Dockerfile edit #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
DebajitDas
reviewed
Mar 14, 2022
| @@ -55,7 +55,7 @@ Monitoring individual modules is crucial to the instrumentation of Apache web se | |||
| |*ApacheModuleServiceNamespace* | | REQUIRED: Logical name of the service | | |||
| |*ApacheModuleServiceInstanceId* | | REQUIRED: The string ID of the service instance | | |||
| |*ApacheModuleTraceAsError* | | OPTIONAL: Trace level for logging to Apache log| | |||
| |*ApacheModuleWebserverContext* | | OPTIONAL: Virtual Host Configuration| | |||
| |*ApacheModuleWebserverContext* | | OPTIONAL: Takes 3 values(space-seperated) Application Name, Node Name, Tier Name| | |||
There was a problem hiding this comment.
Should we say ServiceName, ServiceNamespace and ServiceInstanceId instead?
There was a problem hiding this comment.
Yes, It shows like that in Zipkin, I will change it
DebajitDas
reviewed
Mar 15, 2022
| @@ -95,5 +95,5 @@ The build file can be copied at a suitable location in User's system by running | |||
| ### Maintainers | |||
| * [Kumar Pratyush](https://github.com/kpratyus), Cisco | |||
| * [Lakshay Gaba](https://github.com/lakshay141), Cisco | |||
| * [Debajit Das] (https://github.com/DebajitDas), Cisco | |||
| * [Debajit Das](https://github.com/DebajitDas), Cisco | |||
There was a problem hiding this comment.
This formatting change is no longer required, as this was raised by someone else and I merged that
DebajitDas
approved these changes
Mar 15, 2022
marcalff
added
the
Webserver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is change regarding the issue #111