Httpd add possibility to configure custom attributes and resources #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemk
reviewed
Apr 1, 2021
| @@ -32,4 +32,7 @@ OpenTelemetryPath /tmp/output-spans | |||
|
|
|||
| # OpenTelemetryIgnoreInbound off | |||
|
|
|||
| # OpenTelemetrySetResource service.name apache-web-server | |||
| # OpenTelemetrySetAttribute foo bar | |||
There was a problem hiding this comment.
Are these attributes global, for all routes? Is it possible to set attributes for specific route?
With nginx it's possible to set these per server, route basis.
There was a problem hiding this comment.
At the moment those are global settings.
| @@ -85,8 +85,17 @@ void initTracer() | |||
| processor = std::make_shared<sdktrace::SimpleSpanProcessor>(std::move(exporter)); | |||
| } | |||
|
|
|||
| opentelemetry::sdk::resource::ResourceAttributes resAttrs({{"service.name", "httpd"}}); | |||
There was a problem hiding this comment.
From the spec:
[1]: MUST be the same for all instances of horizontally scaled services. If the value was not specified, SDKs MUST fallback to u nknown_service: concatenated with process.executable.name, e.g. unknown_service:bash. If process.executable.name is not available, the value MUST be set to unknown_service.
There was a problem hiding this comment.
Yes. Thanks. Removed.
| @@ -85,8 +85,17 @@ void initTracer() | |||
| processor = std::make_shared<sdktrace::SimpleSpanProcessor>(std::move(exporter)); | |||
| } | |||
|
|
|||
| opentelemetry::sdk::resource::ResourceAttributes resAttrs({{"service.name", "httpd"}}); | |||
| // add custom-configured resources | |||
| for(auto &it:config.resources) | |||
| @@ -54,6 +55,8 @@ struct OtelConfig | |||
| // context propagation | |||
| bool ignore_inbound; | |||
| OtelPropagation propagation; | |||
| std::unordered_map<std::string, std::string> attribiutes; | |||
lalitb
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.