Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nginx): add Tobias Stadler as codeowner #154

Merged
merged 1 commit into from
May 7, 2022

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Apr 22, 2022

He has been doing most of the PRs as of late and help is greatly appreciated 🙂

See: #144 (comment)

@seemk seemk requested a review from a team April 22, 2022 09:51
@seemk
Copy link
Contributor Author

seemk commented Apr 22, 2022

@tobiasstadler Are you willing to create a membership request to the OpenTelemetry community repo? You need to be a member before you can be added to cpp-contrib-approvers. E.g. similar to open-telemetry/community#699

@tobiasstadler
Copy link
Member

@seemk The PR template says I need two sponsors for membership request. I suppose you are one of them? Do you know who could be the other one?

@seemk
Copy link
Contributor Author

seemk commented Apr 25, 2022

@seemk The PR template says I need two sponsors for membership request. I suppose you are one of them? Do you know who could be the other one?

@lalitb perhaps?

@tobiasstadler
Copy link
Member

@lalitb Are you willing to sponsor me?

@lalitb
Copy link
Member

lalitb commented May 3, 2022

@lalitb Are you willing to sponsor me?

Yes sure.

@tobiasstadler
Copy link
Member

Thank You!

@lalitb lalitb merged commit 6467ec2 into open-telemetry:main May 7, 2022
@marcalff marcalff added instrumentation:nginx Nginx module general General issue, not specific to a particular contrib labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general General issue, not specific to a particular contrib instrumentation:nginx Nginx module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants