Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set server span attributes #179

Merged
merged 32 commits into from
Aug 3, 2022
Merged

Conversation

gnm444
Copy link
Contributor

@gnm444 gnm444 commented Jun 15, 2022

Please review the changes. Two more attributes need to be added. WIP.

@gnm444 gnm444 requested a review from a team June 15, 2022 06:44
@DebajitDas
Copy link
Member

Please update the PR description and refrain from using Appd internal "websrv-698" here. Is this still WIP?

@DebajitDas DebajitDas added the Webserver This represents the otel-webserver-module in the instrumentation directory label Jul 5, 2022
@@ -596,7 +646,7 @@ int ApacheHooks::appd_hook_log_transaction_end(request_rec* r)
/*
End the request and report the associated metrics.
*/

[[]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@DebajitDas
Copy link
Member

Could you please rebase from main and raise the PR and lets see if build is triggered with this? Once builds are passed, we can start review.

@gnm444 gnm444 changed the title WIP: Websrv-698 Set server span attributes Websrv-698 Set server span attributes Jul 8, 2022
@gnm444 gnm444 changed the title Websrv-698 Set server span attributes Set server span attributes Jul 8, 2022
#ifdef APLOG_USE_MODULE

payload->set_client_ip(request->useragent_ip);
if (request->connection)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in Apache 2.2 set_client_ip is not possible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find similar param to set client ip in 2.2

@gnm444 gnm444 changed the base branch from main to webserver-dev July 21, 2022 05:56
@gnm444 gnm444 changed the base branch from webserver-dev to main July 29, 2022 05:51
@gnm444
Copy link
Contributor Author

gnm444 commented Aug 2, 2022

@DebajitDas : Please check

Span #7
collector | Trace ID : b8d0640ea491c835eaea34f96c87d606
collector | Parent ID :
collector | ID : 2bee39f9cd57eed5
collector | Name : /noindex/css
collector | Kind : SPAN_KIND_SERVER
collector | Start time : 2022-08-02 08:14:24.6042542 +0000 UTC
collector | End time : 2022-08-02 08:14:24.6051359 +0000 UTC
collector | Status code : STATUS_CODE_UNSET
collector | Status message :
collector | Attributes:
collector | -> http.client_ip: STRING(172.18.0.1)
collector | -> http.status_code: INT(200)
collector | -> http.flavor: STRING(1.1)
collector | -> http.target: STRING(/noindex/css/fonts/Bold/OpenSans-Bold.ttf)
collector | -> net.host.name: STRING(localhost)
collector | -> net.host.port: INT(80)
collector | -> http.server_name: STRING(172.18.0.4)
collector | -> http.method: STRING(GET)
collector | -> request_protocol: STRING(HTTP/1.1)
collector | -> http.scheme: STRING(http)

Copy link
Member

@DebajitDas DebajitDas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Webserver This represents the otel-webserver-module in the instrumentation directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants