-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set server span attributes #179
Conversation
Please update the PR description and refrain from using Appd internal "websrv-698" here. Is this still WIP? |
@@ -596,7 +646,7 @@ int ApacheHooks::appd_hook_log_transaction_end(request_rec* r) | |||
/* | |||
End the request and report the associated metrics. | |||
*/ | |||
|
|||
[[]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Could you please rebase from main and raise the PR and lets see if build is triggered with this? Once builds are passed, we can start review. |
#ifdef APLOG_USE_MODULE | ||
|
||
payload->set_client_ip(request->useragent_ip); | ||
if (request->connection) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in Apache 2.2 set_client_ip is not possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find similar param to set client ip in 2.2
@DebajitDas : Please check Span #7 |
instrumentation/otel-webserver-module/include/core/api/Payload.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Please review the changes. Two more attributes need to be added. WIP.