Merge from main #181
Merged
Merge from main #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etry#164) * Set span status according to http semantics * Set span status changes part-2 * Set span status according to http semantics spaces * Review comments addressed for span status * Moved error status from Apache hooks to Request processing engine
* Set span status according to http semantics * Set span status changes part-2 * Set span status according to http semantics spaces * Review comments addressed for span status * Moved error status from Apache hooks to Request processing engine * Fixed unit test failure
DebajitDas
added a commit
that referenced
this pull request
Jul 4, 2022
* Added dependencies of Nginx Build (#158) * updated nginx build directory (#159) * nginx source code (#160) * Add license (#162) * Add license * removing Ubuntu condition * Nomenclature changes from Appdynamics to OpenTelemetry (#163) * Changed appd to otel * Added build command for Nginx Module * Added a missing file to be built * Incorporated Review comments * Nginx docker (#167) * Changing docker compose * centos7 * Updated README for Nginx instrumentation (#168) * Updated README for Nginx instrumentation * Updated README.md * Updated README.md * Set span status according to Semantic Conventions of Http (#164) (#169) * Set span status according to http semantics * Set span status changes part-2 * Set span status according to http semantics spaces * Review comments addressed for span status * Moved error status from Apache hooks to Request processing engine Co-authored-by: Narasimha <ngonapa@cisco.com> * Updated error codes (#170) * Merged from Main branch (#172) * Set span status according to Semantic Conventions of Http (#164) * Set span status according to http semantics * Set span status changes part-2 * Set span status according to http semantics spaces * Review comments addressed for span status * Moved error status from Apache hooks to Request processing engine * Fixed UT failure (#171) * Set span status according to http semantics * Set span status changes part-2 * Set span status according to http semantics spaces * Review comments addressed for span status * Moved error status from Apache hooks to Request processing engine * Fixed unit test failure Co-authored-by: Narasimha <ngonapa@cisco.com> * Merge from main (#181) * Set span status according to Semantic Conventions of Http (#164) * Set span status according to http semantics * Set span status changes part-2 * Set span status according to http semantics spaces * Review comments addressed for span status * Moved error status from Apache hooks to Request processing engine * Fixed UT failure (#171) * Set span status according to http semantics * Set span status changes part-2 * Set span status according to http semantics spaces * Review comments addressed for span status * Moved error status from Apache hooks to Request processing engine * Fixed unit test failure Co-authored-by: Narasimha <ngonapa@cisco.com> Co-authored-by: DEBAJIT DAS <85024550+DebajitDas@users.noreply.github.com> Co-authored-by: Narasimha <ngonapa@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.