Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path matching to nginx pull requests, fix nginx docker waiting #20

Merged
merged 3 commits into from
Apr 23, 2021
Merged

Add path matching to nginx pull requests, fix nginx docker waiting #20

merged 3 commits into from
Apr 23, 2021

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Apr 21, 2021 •
edited
Loading

The CI's path matching only triggered for pushes, but not PRs.

Also the tests now wait until nginx comes up, this caused flakiness before.

@seemk seemk changed the title Add path matching to nginx pull requests Add path matching to nginx pull requests, fix nginx docker waiting Apr 21, 2021
TomRoSystems
TomRoSystems approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@TomRoSystems TomRoSystems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalitb lalitb merged commit 426d960 into open-telemetry:main Apr 23, 2021
@lalitb lalitb mentioned this pull request Apr 23, 2021
Merged
@marcalff marcalff added the instrumentation:nginx Nginx module label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomRoSystems TomRoSystems TomRoSystems approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
instrumentation:nginx Nginx module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seemk @lalitb @TomRoSystems @marcalff