Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downstream bug fix #204

Merged
merged 4 commits into from
Sep 6, 2022
Merged

Downstream bug fix #204

merged 4 commits into from
Sep 6, 2022

Conversation

kpratyus
Copy link
Member

Making changes so that only one node is added for request header

@kpratyus kpratyus requested a review from a team August 23, 2022 11:20
DebajitDas
DebajitDas reviewed Aug 29, 2022
View reviewed changes
instrumentation/otel-webserver-module/src/nginx/ngx_http_opentelemetry_module.c Outdated
if(h == NULL){
return;

char* c = httpHeaders[i];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused variable c?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

DebajitDas
DebajitDas approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@DebajitDas DebajitDas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpratyus
Copy link
Member Author

kpratyus commented Sep 5, 2022

LGTM

We can merge after the jobs are completed

@kpratyus kpratyus merged commit 786c3ad into open-telemetry:main Sep 6, 2022
@svrnm svrnm mentioned this pull request Sep 29, 2022
Closed
@marcalff marcalff added the Webserver This represents the otel-webserver-module in the instrumentation directory label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DebajitDas DebajitDas DebajitDas approved these changes

Assignees
No one assigned
Labels
Webserver This represents the otel-webserver-module in the instrumentation directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpratyus @DebajitDas @marcalff