Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mixed readme descriptions #333

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix mixed readme descriptions #333

merged 1 commit into from
Oct 25, 2023

Conversation

thusoy
Copy link
Contributor

@thusoy thusoy commented Oct 17, 2023

Descriptions were mixed for name and namespace for both apace and nginx modules.

@thusoy thusoy requested a review from a team October 17, 2023 09:04
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 17, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: thusoy / name: Tarjei Husøy (320205f)

ThomsonTan
ThomsonTan approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@ThomsonTan ThomsonTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@ThomsonTan ThomsonTan merged commit adad337 into open-telemetry:main Oct 25, 2023
5 checks passed
@thusoy thusoy deleted the mixed-descriptions branch October 26, 2023 06:06
@marcalff marcalff added the Webserver This represents the otel-webserver-module in the instrumentation directory label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@kpratyus kpratyus Awaiting requested review from kpratyus kpratyus is a code owner

@DebajitDas DebajitDas Awaiting requested review from DebajitDas DebajitDas is a code owner

Assignees
No one assigned
Labels
Webserver This represents the otel-webserver-module in the instrumentation directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thusoy @ThomsonTan @marcalff