Skip to content

Commit

Permalink
Remove implicitly deleted default constructor (#1267)
Browse files Browse the repository at this point in the history
Co-authored-by: Tom Tan <Tom.Tan@microsoft.com>
Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
  • Loading branch information
3 people authored Apr 7, 2022
1 parent 6b87300 commit 3122254
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions api/include/opentelemetry/context/runtime_context.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ class Token
private:
friend class RuntimeContextStorage;

Token() noexcept = default;

// A constructor that sets the token's Context object to the
// one that was passed in.
Token(const Context &context) : context_(context) {}
Expand Down

2 comments on commit 3122254

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 3122254 Previous: 6b87300 Ratio
BM_NaiveSpinLockThrashing/2/process_time/real_time 0.5222170960669424 ms/iter 0.23794511778164754 ms/iter 2.19

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 3122254 Previous: 6b87300 Ratio
BM_LockFreeBuffer/1 4534640.073776245 ns/iter 351253.9905845712 ns/iter 12.91
BM_LockFreeBuffer/2 4722756.147384644 ns/iter 1406755.2089691162 ns/iter 3.36

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.