Skip to content

Commit

Permalink
Upgrade opentelemetry-proto to v0.19.0 (#1579)
Browse files Browse the repository at this point in the history
* changes

* add changelog

* update third_party_release
  • Loading branch information
lalitb authored Aug 23, 2022
1 parent ef4136e commit 39d6a22
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ Increment the:

## [Unreleased]

* [BUILD] Upgrade opentelemetry-proto to v0.19.0 [#1579](https://github.com/open-telemetry/opentelemetry-cpp/pull/1579)

## [1.6.0] 2022-08-15

* [METRICS SDK] Calling Observable Instruments callback during metrics
Expand Down
6 changes: 3 additions & 3 deletions bazel/repository.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@ def opentelemetry_cpp_deps():
http_archive,
name = "com_github_opentelemetry_proto",
build_file = "@io_opentelemetry_cpp//bazel:opentelemetry_proto.BUILD",
sha256 = "134ce87f0a623daac19b9507b92da0d9b82929e3db796bba631e422f6ea8d3b3",
strip_prefix = "opentelemetry-proto-0.18.0",
sha256 = "464bc2b348e674a1a03142e403cbccb01be8655b6de0f8bfe733ea31fcd421be",
strip_prefix = "opentelemetry-proto-0.19.0",
urls = [
"https://github.com/open-telemetry/opentelemetry-proto/archive/v0.18.0.tar.gz",
"https://github.com/open-telemetry/opentelemetry-proto/archive/v0.19.0.tar.gz",
],
)

Expand Down
2 changes: 1 addition & 1 deletion cmake/opentelemetry-proto.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/third_party/opentelemetry-proto/.git)
set(needs_proto_download FALSE)
else()
if("${opentelemetry-proto}" STREQUAL "")
set(opentelemetry-proto "v0.17.0")
set(opentelemetry-proto "v0.19.0")
endif()
include(ExternalProject)
ExternalProject_Add(
Expand Down
2 changes: 1 addition & 1 deletion third_party_release
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ benchmark=v1.5.3
googletest=release-1.10.0-459-ga6dfd3ac
ms-gsl=v3.1.0-67-g6f45293
nlohmann-json=v3.10.5
opentelemetry-proto=v0.18.0
opentelemetry-proto=v0.19.0
prometheus-cpp=v1.0.0
vcpkg=2022.04.12

1 comment on commit 39d6a22

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 39d6a22 Previous: ef4136e Ratio
BM_BaselineBuffer/2 7321839.332580566 ns/iter 2598757.50541687 ns/iter 2.82
BM_LockFreeBuffer/1 4054140.329360962 ns/iter 311271.2578469237 ns/iter 13.02
BM_LockFreeBuffer/2 4245477.111152049 ns/iter 1379414.3199920654 ns/iter 3.08

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.