More vs2019 minor warnings cleanup (#675)

open-telemetry · Apr 16, 2021 · b0f27a4 · b0f27a4
1 parent d1f0b13
commit b0f27a4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/api/include/opentelemetry/context/context.h b/api/include/opentelemetry/context/context.h
@@ -140,7 +140,7 @@ class Context
       next_  = nostd::shared_ptr<DataList>{nullptr};
     }
 
-    DataList &operator=(DataList &&other)
+    DataList &operator=(DataList &&other) noexcept
     {
       key_length_ = other.key_length_;
       value_      = std::move(other.value_);

diff --git a/api/include/opentelemetry/context/runtime_context.h b/api/include/opentelemetry/context/runtime_context.h
@@ -58,6 +58,8 @@ class RuntimeContextStorage
    */
   virtual bool Detach(Token &token) noexcept = 0;
 
+  virtual ~RuntimeContextStorage(){};
+
 protected:
   nostd::unique_ptr<Token> CreateToken(const Context &context) noexcept
   {