Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics SDK] Histogram min/max support #1443

Closed
lalitb opened this issue Jun 10, 2022 · 1 comment · Fixed by #1540
Closed

[Metrics SDK] Histogram min/max support #1443

lalitb opened this issue Jun 10, 2022 · 1 comment · Fixed by #1540
Assignees
Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers metrics

Comments

@lalitb
Copy link
Member

lalitb commented Jun 10, 2022

It seems Explicit bucket histogram aggregation should support the optional required configuration for min/max support. This is something missing in the current implementation.

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#explicit-bucket-histogram-aggregation

The summary of changes required:

  • adds min/max recording to Histograms
  • makes this configurable via the Aggregation
  • Update proto to 0.18.0 to make it exportable.

Depends on #1444 - should be possible to configure min/max using configuration

@lalitb lalitb added the metrics label Jun 10, 2022
@lalitb lalitb added help wanted Good for taking. Extra help will be provided by maintainers good first issue Good for newcomers labels Jun 15, 2022
@esigo esigo self-assigned this Jul 16, 2022
@lalitb
Copy link
Member Author

lalitb commented Aug 3, 2022

@esigo - Do you want me to pick this issue, unless you have already started on it :) I would have some bandwidth this week, so checking.

ok please ignore the above. I will work on #1339 first. Looks like, that would take a couple of days. Can take this after that in case you want me to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers metrics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants