[Metrics SDK] Histogram min/max support #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1540 +/- ##
==========================================
+ Coverage 83.90% 83.98% +0.09%
==========================================
Files 156 156
Lines 4873 4905 +32
==========================================
+ Hits 4088 4119 +31
- Misses 785 786 +1
|
ThomsonTan
reviewed
Aug 3, 2022
esigo
changed the title
lalitb
reviewed
Aug 4, 2022
| @@ -147,6 +149,8 @@ TEST(OStreamMetricsExporter, ExportHistogramPointData) | |||
| "\n type : HistogramPointData" | |||
| "\n count : 3" | |||
| "\n sum : 900" | |||
| "\n min : 0" | |||
| "\n max : 0" | |||
There was a problem hiding this comment.
It was because histogram_point_data, had default min and max.
thanks, added proper min & max now.
lalitb
reviewed
Aug 4, 2022
| @@ -21,6 +21,7 @@ class HistogramAggregationConfig : public AggregationConfig | |||
| { | |||
| public: | |||
| std::list<T> boundaries_; | |||
| bool record_min_max_ = true; | |||
There was a problem hiding this comment.
Seems we are setting it, but not using it :).
Pls ignore, it's been used. Sorry about that.
lalitb
reviewed
Aug 4, 2022
| if (merge.record_min_max_) | ||
| { | ||
| merge.min_ = std::min(nostd::get<T>(current.min_), nostd::get<T>(delta.min_)); | ||
| merge.max_ = std::max(nostd::get<T>(current.max_), nostd::get<T>(delta.max_)); |
There was a problem hiding this comment.
Not sure how to handle for HistogramDiff, should we set record_min_max_ to false?
lalitb
approved these changes
Aug 5, 2022
ThomsonTan
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1443 (issue)
Changes
adds min/max recording to Histograms
makes this configurable via the Aggregation
Update proto to 0.18.0 to make it exportable.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes