Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add ci jobs without ENABLE_METRICS_PREVIEW (bazel) and WITH_METRICS_PREVIEW (cmake) #1494

Closed
owent opened this issue Jul 13, 2022 · 3 comments · Fixed by #1531
Closed
Assignees

Comments

@owent
Copy link
Member

owent commented Jul 13, 2022

Is your feature request related to a problem?

I notice the new metrics implement is enabled only when building without ENABLE_METRICS_PREVIEW (bazel) and WITH_METRICS_PREVIEW (cmake). But it's not checked in most CI jobs. I think we should add some steps or jobs to build without them.

@lalitb
Copy link
Member

lalitb commented Jul 13, 2022

This was discussed in today's community meeting - Should we instead remove validating CI builds for old metrics implementation? This would simplify the CI, and also gives a message that the old implementation is going to be cleaned up in the coming days.

@owent
Copy link
Member Author

owent commented Jul 14, 2022

Could we keep few CI jobs for the old metrics, just like LogName in log APIs? There are some projects use the old implements and it will take some time to migrate to the new one.
I think keep one job using bazel with new compiler and one jobs using cmake with gcc 4.8 would be enough.

@esigo
Copy link
Member

esigo commented Aug 11, 2022

gcc 4.8 is already broken for the deprecated metrics. I removed it from #1531.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants