Add CI jobs for new and deprecated metrics #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1531 +/- ##
==========================================
- Coverage 83.38% 83.36% -0.02%
==========================================
Files 156 156
Lines 4975 4975
==========================================
- Hits 4148 4147 -1
- Misses 827 828 +1
|
owent
reviewed
Jul 30, 2022
lalitb
approved these changes
Aug 11, 2022
| @@ -165,7 +181,27 @@ jobs: | |||
| sudo ./ci/install_bazelisk.sh | |||
| - name: run tests | |||
| run: ./ci/do_ci.sh bazel.test | |||
|
|
|||
| bazel_deprecated_metrics_test: | |||
There was a problem hiding this comment.
nit - add newline before and after this test.
owent
approved these changes
Aug 12, 2022
Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1494 (issue)
Changes
makes all jobs testing the new metrics and adds
bazelandcmake,gcc 4.8For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes