Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetricProducer support #1831

Open
2 tasks
dashpole opened this issue Dec 1, 2022 · 2 comments
Open
2 tasks

MetricProducer support #1831

dashpole opened this issue Dec 1, 2022 · 2 comments
Assignees
Labels
area:metrics OpenTelemetry metrics do-not-stale good first issue Good for newcomers priority:p2 Issues that are not blocking

Comments

@dashpole
Copy link
Contributor

dashpole commented Dec 1, 2022

Problem Statement

open-telemetry/opentelemetry-specification#2951 defined an experimental MetricProducer interface, which can be used to support metric bridges. Note that the specifications are experimental, so it isn't critical that it is implemented at this time.

Changes:

@lalitb lalitb added the area:metrics OpenTelemetry metrics label Dec 2, 2022
@lalitb lalitb added this to the Metrics post GA release milestone Dec 2, 2022
@lalitb lalitb added priority:p2 Issues that are not blocking good first issue Good for newcomers labels Dec 2, 2022
@lalitb lalitb self-assigned this Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Feb 4, 2023

This issue was marked as stale due to lack of activity.

@punya
Copy link
Member

punya commented Sep 1, 2024

Notes:

  • The MetricProducer spec has been stable for about a year now.
  • MetricProducer was implemented prior to the creation of this issue, but doesn't match the current (v1.36.0) spec.
  • The spec says we should allow zero or more MetricProducers to be provided to a MetricReader at construction-time, whereas we allow zero or one MetricProducer to be set after construction.

@dashpole is it worth updating the issue text?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics OpenTelemetry metrics do-not-stale good first issue Good for newcomers priority:p2 Issues that are not blocking
Projects
None yet
Development

No branches or pull requests

4 participants