Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] Increase metric name maximum length from 63 to 255 characters #2281

Closed
marcalff opened this issue Aug 30, 2023 · 0 comments · Fixed by #2284
Closed

[SDK] Increase metric name maximum length from 63 to 255 characters #2281

marcalff opened this issue Aug 30, 2023 · 0 comments · Fixed by #2284
Assignees
@marcalff
Labels
bug Something isn't working

Comments

@marcalff
Copy link
Member

Change the metric instrument name length, per the following spec change:
@marcalff marcalff added the bug Something isn't working label Aug 30, 2023
@marcalff marcalff self-assigned this Aug 30, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 30, 2023
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Aug 31, 2023
@marcalff
Fix open-telemetry#2281
110ee31
@marcalff marcalff mentioned this issue Aug 31, 2023
Merged
3 tasks
@marcalff marcalff removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 31, 2023
@marcalff marcalff mentioned this issue Sep 21, 2023
Merged
5 tasks
carlosalberto pushed a commit to open-telemetry/opentelemetry-specification that referenced this issue Sep 22, 2023
@marcalff
Update spec compliance matrix for C++ (metrics instrument names) (#3703)
5f9bc69 
## Changes

Updated the following entry in the spec compliance matrix:

* Section Metrics, item "Instrument names conform to the specified
syntax."
* Language C++

The lastest spec changes (#3648, #3422) are implemented by the following
PR:

* open-telemetry/opentelemetry-cpp#2281
* open-telemetry/opentelemetry-cpp#2303

so C++ can be marked compliant with the specification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcalff marcalff

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SDK] Increase metric name maximum length from 63 to 255 characters marcalff/opentelemetry-cpp
1 participant
@marcalff