Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAVE_CPP_STDLIB and HAVE_GSL should be auto added when using -DWITH_STL=ON with cmake. #741

Closed
owent opened this issue May 11, 2021 · 1 comment
Closed

HAVE_CPP_STDLIB and HAVE_GSL should be auto added when using -DWITH_STL=ON with cmake. #741

owent opened this issue May 11, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@owent
Copy link
Member

owent commented May 11, 2021

Describe your environment
Windows, CMake

Steps to reproduce
Using cmake -DWITH_STL=ON ... to build project.

What is the expected behavior?
HAVE_CPP_STDLIB and HAVE_GSL should be added into INTERFACE_COMPILE_DEFINITIONS of exported target opentelemetry-cpp::api .

What is the actual behavior?
Nothing here.

Additional context
@owent owent added the bug Something isn't working label May 11, 2021
owent pushed a commit to owent/opentelemetry-cpp that referenced this issue May 11, 2021
Fix issues open-telemetry#740 and open-telemetry#741
8f46e20 
Signed-off-by: owent <owent@tencent.com>
@owent owent mentioned this issue May 11, 2021
Merged
3 tasks
owent added a commit to owent/opentelemetry-cpp that referenced this issue May 11, 2021
@owent
Fix issues open-telemetry#740 and open-telemetry#741
c0e2def 
Signed-off-by: owent <owent@tencent.com>
owent added a commit to owent/opentelemetry-cpp that referenced this issue May 11, 2021
@owent
Fix issues open-telemetry#740 and open-telemetry#741
4d828f8 
Signed-off-by: owent <admin@owent.net>
owent added a commit to owent/opentelemetry-cpp that referenced this issue May 11, 2021
@owent
Fix open-telemetry#740 open-telemetry#741
d2131aa 
Signed-off-by: owent <admin@owent.net>
owent added a commit to owent/opentelemetry-cpp that referenced this issue May 12, 2021
@owent
Fix open-telemetry#740 open-telemetry#741
e6277a5 
Signed-off-by: owent <admin@owent.net>
owent added a commit to owent/opentelemetry-cpp that referenced this issue May 14, 2021
@owent
Fix open-telemetry#740 open-telemetry#741
a63991e 
Signed-off-by: owent <admin@owent.net>
lalitb pushed a commit that referenced this issue May 14, 2021
@owent
Fix issues #740 and #741 (#742)
0d94c01
@owent
Copy link
Member Author

owent commented May 14, 2021

Closed by #742

@owent owent closed this as completed May 14, 2021
@owent owent mentioned this issue Nov 24, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@owent