Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document DefaultSpan #956

Closed
jsuereth opened this issue Aug 19, 2021 · 0 comments · Fixed by #959
Closed

Document DefaultSpan #956

jsuereth opened this issue Aug 19, 2021 · 0 comments · Fixed by #959
Labels
spec-compliance Not compliant to OpenTelemetry specs

Comments

@jsuereth
Copy link
Contributor

AFAICT, DefaultSpan solves this portion of the spec:

A SpanContext cannot be set as active in a Context directly, but by wrapping it into a Span. For example, a Propagator performing context extraction may need this.

The class should (at a minimum) have documentation.

@jsuereth jsuereth added the spec-compliance Not compliant to OpenTelemetry specs label Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-compliance Not compliant to OpenTelemetry specs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant