Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document DefaultSpan, remove DefaultTracer #959

Merged
merged 4 commits into from
Aug 25, 2021

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Aug 24, 2021

Fixes #956 , #949

Changes

cc @jsuereth

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team August 24, 2021 21:38
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #959 (22bf451) into main (115a136) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #959   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files         160      160           
  Lines        6780     6780           
=======================================
  Hits         6465     6465           
  Misses        315      315           
Impacted Files Coverage Δ
api/include/opentelemetry/trace/default_span.h 14.29% <ø> (ø)

@ThomsonTan ThomsonTan merged commit 61d3c5e into open-telemetry:main Aug 25, 2021
@lalitb lalitb mentioned this pull request Sep 17, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document DefaultSpan
2 participants