-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed template args from the constructor declarations #1011
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. You have to sign the CLA to get this through :)
Codecov Report
@@ Coverage Diff @@
## main #1011 +/- ##
=======================================
Coverage 94.85% 94.85%
=======================================
Files 151 151
Lines 5972 5972
=======================================
Hits 5664 5664
Misses 308 308 |
Can some one please let me know some info on how to fix two failures above? format and EasyCLA. I did signed the agreement however. |
easyCLA: https://docs.linuxfoundation.org/lfx/easycla/v1-deprecated/contributors/individual-contributor If you have already signed the agreement, probably it gets fixed with the next commit to this PR. Let us know if it doesn't work. |
@manushawijekoon do you still need more instructions to fix CLA and format? |
#1029 fixes this issue, so closing the PR. |
Fixes # (1010)
Changes
Please provide a brief description of the changes here.
Removed template params from constructor declaration to comly with c++20 standard.