Implementation of OtlpHttpLogExporter
#1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1030 +/- ##
=======================================
Coverage 94.85% 94.85%
=======================================
Files 151 151
Lines 5972 5972
=======================================
Hits 5664 5664
Misses 308 308
|
owent
force-pushed
the
otlp_log_exporter
branch
3 times, most recently
from
e218d81
to
609ab83
Compare
|
@owent Thanks for the PR. Changes look good to me in general. I will be doing a more thorough review next couple of days. |
cbandy
reviewed
Oct 28, 2021
exporters/otlp/include/opentelemetry/exporters/otlp/otlp_environment.h
Outdated
Show resolved
Hide resolved
lalitb
approved these changes
Oct 28, 2021
exporters/otlp/include/opentelemetry/exporters/otlp/otlp_recordable_utils.h
Show resolved
Hide resolved
owent
force-pushed
the
otlp_log_exporter
branch
from
609ab83
to
8f738aa
Compare
ThomsonTan
reviewed
Oct 29, 2021
ThomsonTan
reviewed
Oct 29, 2021
ThomsonTan
reviewed
Oct 29, 2021
exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_client.h
Outdated
Show resolved
Hide resolved
ThomsonTan
reviewed
Oct 30, 2021
ThomsonTan
approved these changes
Oct 30, 2021
|
@owent will merge it once it is updated to main. |
+ Finish `OtlpLogRecordable`. Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owent <admin@owent.net>
Signed-off-by: owent <admin@owent.net>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Support old protobuf for OtlpHttp*Exporter Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
…nt.cc` Signed-off-by: owent <admin@owent.net>
owent
force-pushed
the
otlp_log_exporter
branch
from
af459e4
to
86cdc9c
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1024
Changes
OtlpRecordableUtils.OtlpHttpClientand move shared codes of HTTP exportor into this target .OtlpHttpLogExporter.@ThomsonTan @lalitb Could you please review the codes? There should be no API break change by now. Unit tests are already added.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes