Building otlp exporter from the release tarball #1056
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1056 +/- ##
=======================================
Coverage 94.85% 94.85%
=======================================
Files 151 151
Lines 5971 5971
=======================================
Hits 5663 5663
Misses 308 308 |
| set(${third_party_name} "${third_party_tag}") | ||
| endforeach() | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Trying to understand the logic here. We iterate the file and extract the name and version from each entry. In the end, third_party_name and third_party_tag contain name and version for last entry of file. What are we going to do with the last entry?
There was a problem hiding this comment.
No we are storing all the versions not just the last one. e.g. ${nlohmann-json} has v3.9.1, or ${opentelemetry-proto} has, v0.11.0.
In this PR I use ${opentelemetry-proto} to download it from github.
We can use the same technique for all the other dependencies when they are not available in the third_party folder.
There was a problem hiding this comment.
Ah got it, I missed the set command.
| set(PROTO_PATH "${CMAKE_CURRENT_SOURCE_DIR}/third_party/opentelemetry-proto") | ||
| set(needs_proto_download FALSE) | ||
| else() | ||
| if("${opentelemetry-proto}" STREQUAL "") |
There was a problem hiding this comment.
how would this be defined to point to a specific version/branch?
| set(${third_party_name} "${third_party_tag}") | ||
| endforeach() | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Ah got it, I missed the set command.
Fixes #1051 (issue)
Changes
Please provide a brief description of the changes here.
download opentelemtery-proto if it's not stored.
Read opentelemtery-proto tag from file if not available use main.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes