Fix #1081 #1082
Merged
Fix #1081 #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1082 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 158 158
Lines 6077 6077
=======================================
Hits 5737 5737
Misses 340 340 |
lalitb
approved these changes
Nov 22, 2021
| return private_resource_; | ||
| proto::resource::v1::Resource proto; | ||
| OtlpRecordableUtils::PopulateAttribute( | ||
| &proto, opentelemetry::sdk::resource::Resource::Create(resource_attributes_)); |
There was a problem hiding this comment.
This is fine for now. But the actual fix should be the improvement in LoggerProvider, to let the resources and instrumentation library passed through it ( similar to what we do with TracerProvider). I will create an issue for the improvements.
There was a problem hiding this comment.
Agree strongly. I could help to do this if there is any need
There was a problem hiding this comment.
Thanks. We can merge this PR. Meanwhile, have added #1086 if you would like to pick it up.
| } // namespace exporter | ||
| OPENTELEMETRY_END_NAMESPACE | ||
|
|
||
| #endif |
There was a problem hiding this comment.
Thanks for adding the recordable tests.
Signed-off-by: owent <admin@owent.net>
Signed-off-by: owentou <owentou@tencent.com>
ThomsonTan
approved these changes
Nov 23, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: owent admin@owent.net
Fixes #1081
Changes
opentelemetry::sdk::resource::Resource::Createto inherit data from default resource andResourceDetector.OtlpLogRecordableFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes