Jaeger exporter: extend supported attributes types #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esigo
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1106 +/- ##
=======================================
Coverage 93.39% 93.39%
=======================================
Files 165 165
Lines 6229 6229
=======================================
Hits 5817 5817
Misses 412 412 |
reyang
reviewed
Nov 30, 2021
reyang
approved these changes
Nov 30, 2021
lalitb
reviewed
Nov 30, 2021
exporters/jaeger/src/recordable.cc
Outdated
| @@ -19,10 +20,26 @@ void JaegerRecordable::PopulateAttribute(nostd::string_view key, | |||
| const common::AttributeValue &value, | |||
| std::vector<thrift::Tag> &tags) | |||
| { | |||
| if (nostd::holds_alternative<int64_t>(value)) | |||
| if (nostd::holds_alternative<int>(value)) | |||
There was a problem hiding this comment.
shouldn't we be comparing only for the supported types from here:
So, int, uint64_t are not valid attribute types.
There was a problem hiding this comment.
thanks, removed unsupported types
unit test bazel
…m/esigo/opentelemetry-cpp into Jaeger-exporter--attributes-types
…m/esigo/opentelemetry-cpp into Jaeger-exporter--attributes-types
@reyang done |
lalitb
approved these changes
Dec 4, 2021
|
Can be merged once the conflict is resolved. |
ThomsonTan
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1104 (issue)
Changes
Please provide a brief description of the changes here.
adds support for the missing types. if not logs an error.
Also bazel unit test build added.
Fixed compiler warnings in the unit test.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes