Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++20 not Building with VS2019 #1144

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

esigo
Copy link
Member

@esigo esigo commented Dec 15, 2021

Fixes #1121 (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team December 15, 2021 21:19
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #1144 (8965523) into main (5aa6327) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1144   +/-   ##
=======================================
  Coverage   93.39%   93.39%           
=======================================
  Files         165      165           
  Lines        6229     6229           
=======================================
  Hits         5817     5817           
  Misses        412      412           

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Do you know why it is passing in our C++ pipeline here. Probably std::result_of is only used in the case of specific exporters which don't get tested against C++20 in our CI.

@esigo
Copy link
Member Author

esigo commented Dec 15, 2021

Thanks for the fix. Do you know why it is passing in our C++ pipeline here. Probably std::result_of is only used in the case of specific exporters which don't get tested against C++20 in our CI.

It seems gcc has not removed std::result_of yet.

@lalitb lalitb merged commit b021bd6 into open-telemetry:main Dec 16, 2021
@esigo esigo deleted the C++20-Building-with-VS2019 branch December 16, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++17 and C++20 not Building with VS2019
3 participants