Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZipkinExporter unit-tests #1155

Merged
merged 11 commits into from
Jan 6, 2022
Merged

Conversation

esigo
Copy link
Member

@esigo esigo commented Dec 20, 2021

Fixes #1143 (issue)

Changes

Add unit tests for ZipkinExporter.
For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #1155 (1534515) into main (1688c7c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1155   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         174      174           
  Lines        6402     6402           
=======================================
  Hits         5972     5972           
  Misses        430      430           

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

exporters/zipkin/test/zipkin_exporter_test.cc Show resolved Hide resolved
@esigo esigo marked this pull request as ready for review December 21, 2021 11:18
@esigo esigo requested a review from a team December 21, 2021 11:18
@bjosv bjosv mentioned this pull request Dec 21, 2021
3 tasks
@lalitb lalitb merged commit f20f72f into open-telemetry:main Jan 6, 2022
@esigo esigo deleted the ZipkinExporter-unit-tests branch January 6, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit-test for Zipkin exporter
3 participants