Ostream metric exporter #1196
Merged
Ostream metric exporter #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1196 +/- ##
==========================================
- Coverage 92.99% 92.96% -0.02%
==========================================
Files 196 196
Lines 7038 7040 +2
==========================================
Hits 6544 6544
- Misses 494 496 +2
|
lalitb
reviewed
Feb 11, 2022
| * @param records a span of unique pointers to metrics recordables | ||
| */ | ||
| sdk::common::ExportResult Export( | ||
| const nostd::span<std::unique_ptr<opentelemetry::sdk::metrics::Recordable>> &records) noexcept |
There was a problem hiding this comment.
Can we modify this class, and the base class to accept span of MetricData instead of recordable?
…etry-cpp into ostream-metrics-exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1091 and #1092 (issue)
For a Metric Reader implementation e.g. Periodic exporting MetricReader
we need a metric exporter.
Changes
This PR implements basic ostream metric exporter based on the current api.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes