Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement Aggregation Storage #1198

Closed
wants to merge 2 commits into from

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Feb 8, 2022

Fixes #1197

Changes

Initial implementation for Aggregation Storage. This will be improved over in future PRs.

This PR is dependent on #1184 to be merged. Will make it ready for review after that.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team February 8, 2022 00:11
@lalitb lalitb marked this pull request as draft February 8, 2022 00:11
@lalitb lalitb changed the title Implement Aggregation Storage [WIP] Implement Aggregation Storage Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #1198 (7717183) into main (44795b6) will increase coverage by 0.06%.
The diff coverage is 75.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1198      +/-   ##
==========================================
+ Coverage   93.44%   93.50%   +0.06%     
==========================================
  Files         185      184       -1     
  Lines        6720     6714       -6     
==========================================
- Hits         6279     6277       -2     
+ Misses        441      437       -4     
Impacted Files Coverage Δ
...pentelemetry/sdk/metrics/aggregation/aggregation.h 100.00% <ø> (ø)
...ry/sdk/metrics/aggregation/histogram_aggregation.h 75.00% <0.00%> (ø)
...ry/sdk/metrics/aggregation/lastvalue_aggregation.h 0.00% <0.00%> (ø)
...elemetry/sdk/metrics/aggregation/sum_aggregation.h 75.00% <0.00%> (ø)
...ntelemetry/sdk/metrics/view/attributes_processor.h 81.25% <ø> (ø)
sdk/include/opentelemetry/sdk/metrics/view/view.h 66.67% <0.00%> (+3.04%) ⬆️
sdk/test/metrics/view_registry_test.cc 100.00% <ø> (ø)
...k/src/metrics/aggregation/histogram_aggregation.cc 100.00% <100.00%> (ø)
...k/src/metrics/aggregation/lastvalue_aggregation.cc 100.00% <100.00%> (ø)
sdk/src/metrics/aggregation/sum_aggregation.cc 100.00% <100.00%> (ø)
... and 2 more

@lalitb
Copy link
Member Author

lalitb commented Mar 23, 2022

changes done as part of #1265

1 similar comment
@lalitb
Copy link
Member Author

lalitb commented Mar 23, 2022

changes done as part of #1265

@lalitb lalitb closed this Mar 23, 2022
@lalitb lalitb closed this Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics SDK] Implement Writable Storage for Aggregation
1 participant