fix ostream_log_test Mac #1208
Merged
fix ostream_log_test Mac #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1208 +/- ##
=======================================
Coverage 93.35% 93.35%
=======================================
Files 193 193
Lines 6908 6908
=======================================
Hits 6448 6448
Misses 460 460 |
lalitb
approved these changes
Feb 14, 2022
ThomsonTan
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1187 (issue)
Changes
The issue is because of
std::unordered_mapthat is used for printing resource attributes. The order in printing is not guaranteed. In this PR the key-value pairs are tested one-by-one.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes