Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage using codecov.io #121

Merged
merged 27 commits into from
Jun 19, 2020
Merged

Add code coverage using codecov.io #121

merged 27 commits into from
Jun 19, 2020

Conversation

Brandon-Kimberly
Copy link
Contributor

This is my cut at integrating code coverage with the OpenTelemetry C++ API/SDK repository using codecov.io.

Code coverage tools incentivize developers to write tests and increase coverage. Codecov.io adds additional functionality such as easy-to-use coverage visualizations, PR coverage comment bots, and commit status badges.

I added a new job to the GitHub Actions CI file that runs on every commit and PR against the master branch titled codecov_upload. This job executes a new branch I added to the do_ci.sh file, titled code.coverage. This branch builds the project using CMake, runs CMake tests, generates a coverage report using lcov, then uploads that report to codecov.io.

I used the default YAML config file (.github/.codecov.yaml) with two adjustments.

  1. Increased the “green” or ideal coverage lower-bound from 70% to 80%.
  2. Included relative file path fixes required by codecov.io to process the report.

Current coverage data for the repository can be found here. Please check it out and let me know if all of the correct files are included.

@Brandon-Kimberly Brandon-Kimberly requested a review from a team June 18, 2020 20:59
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c86794e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #121   +/-   ##
=========================================
  Coverage          ?   93.60%           
=========================================
  Files             ?       66           
  Lines             ?     1564           
  Branches          ?        0           
=========================================
  Hits              ?     1464           
  Misses            ?      100           
  Partials          ?        0           

ci/README.md Outdated Show resolved Hide resolved
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Brandon-Kimberly and others added 2 commits June 18, 2020 17:55
Co-authored-by: Reiley Yang <reyang@microsoft.com>
@reyang reyang merged commit 1a54e5d into open-telemetry:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants