Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always on sampler #122

Merged
merged 50 commits into from
Jun 29, 2020
Merged

Always on sampler #122

merged 50 commits into from
Jun 29, 2020

Conversation

ziqizh
Copy link
Contributor

@ziqizh ziqizh commented Jun 19, 2020

Implements AlwayOnSampler based on the sampler interface in #118.

@ziqizh ziqizh requested a review from a team June 19, 2020 19:14
@ziqizh ziqizh force-pushed the always-on-sampler branch from 28a09a4 to 78b5be0 Compare June 19, 2020 19:23
@ziqizh ziqizh marked this pull request as ready for review June 22, 2020 22:04
sdk/include/opentelemetry/sdk/trace/sampler.h Outdated Show resolved Hide resolved
sdk/include/opentelemetry/sdk/trace/sampler.h Outdated Show resolved Hide resolved
sdk/include/opentelemetry/sdk/trace/sampler.h Outdated Show resolved Hide resolved
sdk/include/opentelemetry/sdk/trace/sampler.h Outdated Show resolved Hide resolved
@pyohannes pyohannes mentioned this pull request Jun 26, 2020
Copy link
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang reyang merged commit 79b6141 into open-telemetry:master Jun 29, 2020
nadiaciobanu pushed a commit to nadiaciobanu/opentelemetry-cpp that referenced this pull request Jul 2, 2020
@reyang reyang mentioned this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants