-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asynchronous Aggregation storage #1232
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1232 +/- ##
==========================================
+ Coverage 92.31% 92.37% +0.06%
==========================================
Files 198 202 +4
Lines 7281 7335 +54
==========================================
+ Hits 6721 6775 +54
Misses 560 560
|
|
Thanks, it was issue in the test code, have fixed it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR :)
Fixes #1218
Changes
The flow of measurement for Asynchronous instrument would be:
Metric Collection Operation
->AsynMetricStorage::Collect()
->measurement_callback(observer_result)
->ObserverResult::Observe()
->AttributeProcessor::Process()
->Aggregation::Aggregate()
->AttributeHashMap::Insert()
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes