OTLP gRPC Metrics Exporter #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1454 +/- ##
==========================================
+ Coverage 85.30% 85.30% +0.01%
==========================================
Files 154 154
Lines 4373 4374 +1
==========================================
+ Hits 3730 3731 +1
Misses 643 643
|
ThomsonTan
reviewed
Jun 17, 2022
exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter.h
Outdated
Show resolved
Hide resolved
ThomsonTan
reviewed
Jun 17, 2022
exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter.h
Outdated
Show resolved
Hide resolved
ThomsonTan
reviewed
Jun 17, 2022
exporters/otlp/include/opentelemetry/exporters/otlp/otlp_populate_attribute_utils.h
Show resolved
Hide resolved
ThomsonTan
reviewed
Jun 18, 2022
ThomsonTan
approved these changes
Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1450
Changes
Adds initial implementation of OTLP gRPC exporter for metrics. While this is ready for review, I am currently adding
Unit testsHistogram exportas part of this PR.
Also, the bazel build is breaking for nit issue. Will be fixing that too.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes