Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trace sdk builder 1393 #1471

Merged
merged 21 commits into from
Jul 15, 2022

Commits on Jun 30, 2022

  1. Draft - work in progress

    [Trace SDK] Implement builders (open-telemetry#1393)
    marcalff committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    6861368 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    af9a5f2 View commit details
    Browse the repository at this point in the history
  3. [Trace SDK] Implement builders (open-telemetry#1393)

    Fixed bazel build, clang-format.
    marcalff committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    777a4fc View commit details
    Browse the repository at this point in the history
  4. [Trace SDK] Implement builders (open-telemetry#1393)

    Format cleanup.
    marcalff committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    356ef47 View commit details
    Browse the repository at this point in the history
  5. [Trace SDK] Implement builders (open-telemetry#1393)

    Use std::unique_ptr instead of nostd::unique_ptr
    marcalff committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    250bcde View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. [Trace SDK] Implement builders (open-telemetry#1393)

    Continued, implemented:
    - JaegerExporterFactory,
    - InMemorySpanExporterFactory,
    - RandomIdGeneratorFactory.
    marcalff committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    7041253 View commit details
    Browse the repository at this point in the history
  2. [Trace SDK] Implement builders (open-telemetry#1393)

    Added doc.
    Makefile format.
    marcalff committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    a176c4c View commit details
    Browse the repository at this point in the history
  3. [Trace SDK] Implement builders (open-telemetry#1393)

    Misc cleanup.
    marcalff committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    c94c174 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Configuration menu
    Copy the full SHA
    89fbfbe View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. [Trace SDK] Implement builders (open-telemetry#1393)

    Implemented code review comments:
    - reworded docs/cpp-sdk-factory-design.md,
    - re organized includes,
    - added TracerContextFactory.
    
    Also:
    - renamed Build() methods to Create(),
      for consistency with HttpClientFactory::Create(),
    - added doxygen comments,
    - added CHANGELOG entry.
    marcalff committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    bfc1030 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2022

  1. Merge branch 'main' into fix_trace_sdk_builder_1393

    Conflicts:
    	CHANGELOG.md
    	exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter.h
    marcalff committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    8a4eadc View commit details
    Browse the repository at this point in the history
  2. [Trace SDK] Implement builders (open-telemetry#1393)

    Implement code review comments:
    - Factory methods should return a unique_ptr.
    - Used TracerContextFactory in examples.
    marcalff committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    f8fe74d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    83e7a1c View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. [Trace SDK] Implement builders (open-telemetry#1393)

    Implement code review comments:
    - avoid copy of resource parameters (used const reference)
    - added unit tests to verify build sanity
    - moved JsonBytesMappingKind and HttpRequestContentType
      to their own header, to avoid the dependency
      on protobuf from otlp_http_client.h
    marcalff committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    755df64 View commit details
    Browse the repository at this point in the history
  2. [Trace SDK] Implement builders (open-telemetry#1393)

    Fixed makefiles.
    marcalff committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    9cd6bb9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2ad543a View commit details
    Browse the repository at this point in the history
  4. [Trace SDK] Implement builders (open-telemetry#1393)

    Unit test cleanup
    marcalff committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    9077623 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. Configuration menu
    Copy the full SHA
    08fb578 View commit details
    Browse the repository at this point in the history
  2. [Trace SDK] Implement builders (open-telemetry#1393)

    CMake cleanup.
    
    Reverted the renaming of library opentelemetry_exporter_in_memory to
    opentelemetry_exporter_memory_trace.
    
    The name opentelemetry_exporter_in_memory is used externally,
    in cmake/opentelemetry-cpp-config.cmake.in
    marcalff committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    1dea7f3 View commit details
    Browse the repository at this point in the history
  3. [Trace SDK] Implement builders (open-telemetry#1393)

    Format makefile.
    marcalff committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    d4b651e View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. [Trace SDK] Implement builders (open-telemetry#1393)

    Fixed grammar in documentation.
    marcalff committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    40217d5 View commit details
    Browse the repository at this point in the history