Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1484 (Rename OTLP gRPC metric exporter) #1488

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jul 11, 2022

Fixes #1484

Changes

Rename

  • OtlpGrpcMetricsExporter to OtlpGrpcMetricExporter
  • OtlpGrpcMetricsExporterOptions to OtlpGrpcMetricExporterOptions
  • OtlpMetricsUtils to OtlpMetricUtils

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team July 11, 2022 22:58
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1488 (dda3817) into main (8691a2d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1488   +/-   ##
=======================================
  Coverage   84.67%   84.67%           
=======================================
  Files         155      155           
  Lines        4787     4787           
=======================================
  Hits         4053     4053           
  Misses        734      734           

@lalitb lalitb merged commit 235c90e into open-telemetry:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics] Otlp metric gRPC exporter has a wrong name.
2 participants