Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bazel build for metrics proto files #1489

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jul 12, 2022

Changes

~/bazel/opentelemetry_proto.BUILD file only contains the build rules for traces and logs. Adding build rules for metrics too.

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team July 12, 2022 00:14
@ThomsonTan
Copy link
Contributor

Is OTLP gRPC metrics exporter enabled in bazel?

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1489 (936b8c7) into main (235c90e) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1489      +/-   ##
==========================================
+ Coverage   84.65%   84.67%   +0.03%     
==========================================
  Files         155      155              
  Lines        4787     4787              
==========================================
+ Hits         4052     4053       +1     
+ Misses        735      734       -1     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 91.41% <0.00%> (+0.79%) ⬆️

@lalitb
Copy link
Member Author

lalitb commented Jul 12, 2022

Is OTLP gRPC metrics exporter enabled in bazel?

Not yet, will create a PR for that once this is merged.

@lalitb lalitb merged commit 801ebba into open-telemetry:main Jul 12, 2022
@lalitb lalitb mentioned this pull request Jul 12, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants