-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple async callbacks #1495
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1495 +/- ##
==========================================
- Coverage 84.57% 83.72% -0.85%
==========================================
Files 156 156
Lines 4795 4850 +55
==========================================
+ Hits 4055 4060 +5
- Misses 740 790 +50
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the RP.
I had some minor comments.
sdk/include/opentelemetry/sdk/metrics/state/async_metric_storage.h
Outdated
Show resolved
Hide resolved
sdk/include/opentelemetry/sdk/metrics/state/async_metric_storage.h
Outdated
Show resolved
Hide resolved
sdk/include/opentelemetry/sdk/metrics/state/async_metric_storage.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR :)
Fixes #1338
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes