Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compiler warnings #1499

Merged
merged 2 commits into from
Jul 17, 2022
Merged

fix compiler warnings #1499

merged 2 commits into from
Jul 17, 2022

Conversation

esigo
Copy link
Member

@esigo esigo commented Jul 17, 2022

Fixes some metrics compiler warnings

Changes

added a virtual dtor, removed unused variables also fixed init order.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team July 17, 2022 12:27
@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #1499 (985c0b4) into main (e708de5) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
- Coverage   84.76%   84.71%   -0.04%     
==========================================
  Files         155      155              
  Lines        4787     4787              
==========================================
- Hits         4057     4055       -2     
- Misses        730      732       +2     
Impacted Files Coverage Δ
sdk/src/metrics/state/sync_metric_storage.cc 100.00% <ø> (ø)
...ntelemetry/sdk/metrics/view/attributes_processor.h 100.00% <100.00%> (ø)
sdk/src/metrics/metric_reader.cc 63.89% <100.00%> (ø)
...include/opentelemetry/sdk/common/circular_buffer.h 98.00% <0.00%> (-2.00%) ⬇️
ext/src/http/client/curl/http_client_curl.cc 81.07% <0.00%> (-0.37%) ⬇️

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@lalitb lalitb merged commit fba16c6 into open-telemetry:main Jul 17, 2022
@esigo esigo deleted the compiler-warnings branch July 17, 2022 18:48
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
* fix compiler warnings

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants