Fix default Metric view name #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esigo
added
bug
Codecov Report
@@ Coverage Diff @@
## main #1515 +/- ##
==========================================
+ Coverage 83.85% 83.91% +0.07%
==========================================
Files 156 156
Lines 4908 4908
==========================================
+ Hits 4115 4118 +3
+ Misses 793 790 -3
|
lalitb
reviewed
Aug 2, 2022
| EXPECT_EQ(view.GetAggregationType(), AggregationType::kDefault); | ||
| return true; | ||
| }); | ||
| # if HAVE_WORKING_REGEX |
There was a problem hiding this comment.
Oh, I forgot to create an issue to support this for gcc4.8. Will create one.
lalitb
reviewed
Aug 2, 2022
| { | ||
| return false; | ||
| } | ||
| createView(instrument_descriptor, instrumentation_scope); |
There was a problem hiding this comment.
Just thinking if we just create a static view with the empty name:
if (!found)
{
static View view("");
. . .
}
And then this part of code -
opentelemetry-cpp/sdk/src/metrics/meter.cc
Line 212 in 90fd291
InstrumentDescriptor.
There was a problem hiding this comment.
@esigo - pinging just in case these comments got missed :)
There was a problem hiding this comment.
@lalitb thanks, I use static view now.
ThomsonTan
reviewed
Aug 9, 2022
| @@ -64,7 +64,7 @@ class ViewRegistry | |||
| // return default view if none found; | |||
| if (!found) | |||
| { | |||
| static View view("otel-default-view"); | |||
| static View view(""); | |||
There was a problem hiding this comment.
Could this be declared as static const?
There was a problem hiding this comment.
thanks, yes I changed to const.
ThomsonTan
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1510 (issue)
Changes
when the view is not registered, creates and registers a new view with the provided information.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes